Rename IRewritableQueryable to IExpressiveQueryable#24
Open
Rename IRewritableQueryable to IExpressiveQueryable#24
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ExpressiveSharp Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3cd8629 | Previous: 6e97f07 | Ratio |
|---|---|---|---|
ExpressiveSharp.Benchmarks.ExpressionResolverBenchmarks.Resolve_Method |
11.208443387810673 ns (± 1.2602965098899765) |
7.273979337679015 ns (± 0.39550929039821486) |
1.54 |
ExpressiveSharp.Benchmarks.ExpressionResolverBenchmarks.Resolve_MethodWithParams |
10.672629095870873 ns (± 0.7365444350386187) |
7.080222995808492 ns (± 0.0473124004879143) |
1.51 |
ExpressiveSharp.Benchmarks.ExpressionResolverBenchmarks.ResolveViaReflection_Property |
8.484306517491738 ns (± 0.01593755937468473) |
5.569200292743486 ns (± 0.007995431982525373) |
1.52 |
ExpressiveSharp.Benchmarks.ExpressionResolverBenchmarks.ResolveViaReflection_Constructor |
9.115078978506583 ns (± 0.5411135431459257) |
5.624050779938698 ns (± 0.0054523658399021095) |
1.62 |
This comment was automatically generated by workflow using github-action-benchmark.
…XP0022 analyzers for missing imports
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| private async Task<ImmutableArray<Diagnostic>> GetDiagnosticsAsync(string source) | ||
| { | ||
| var workspace = new Microsoft.CodeAnalysis.AdhocWorkspace(); |
Comment on lines
+98
to
+102
| foreach (var iface in type.AllInterfaces) | ||
| { | ||
| if (IsExpressiveQueryableType(iface)) | ||
| return true; | ||
| } |
Comment on lines
+51
to
+55
| foreach (var usingDirective in compilationUnit.Usings) | ||
| { | ||
| if (usingDirective.Name?.ToString() == requiredNamespace) | ||
| return root; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the interface to better reflect its purpose and functionality within the context of expressive querying. This change enhances clarity and consistency in the codebase.
This is a breaking change